Link directly to versioned changelog from gemspec #522
Conversation
With this code it will generate this diff. And this link takes you
directly to the changelog.
--- a/addressable.gemspec
+++ b/addressable.gemspec
@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
s.version = "2.8.5"
s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
- s.metadata = { "changelog_uri" => "https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md" } if s.respond_to? :metadata=
+ s.metadata = { "changelog_uri" => "https://github.com/sporkmonger/addressable/blob/addressable-2.8.5/CHANGELOG.md" } if s.respond_to? :metadata=
s.require_paths = ["lib".freeze]
s.authors = ["Bob Aman".freeze]
s.date = "2023-08-03"
|
I'm not sure about this change, the changelog can be updated after release too. For example, if we forgot something. |
|
I didn't think, would be nice handle it somehow. I have a new idea. Since the title don't change we can do Should I update the PR to this so you can see it for yourself? |
|
Sure, that's a good idea. Not sure I follow the last part though, does the actual CHANGELOG file need updating too? It would be best if it could be kept as-is and we make the changelog link be on the already auto-generated format |
|
Ah, NM, I see what you're getting at. Yeah, I'd be fine with using an anchor link too. |
|
For all other project where I have seen changelog links to specific version, it has linked to the tag but as dentarg mentioned. We might want to add something to the changelog after the tag was made |
This allows us to update the changelog after the tag was made.
|
So I have make some improvements. Which one do you prefer, should I drop the last commit? |
|
Sure, this looks good to me I will just point out that it seems to work without |
|
it is updated |
dentarg
changed the title
I like it a lot when the changelog url on rubygems link directly to the versions I updated to